Demogorgon314 commented on code in PR #22983:
URL: https://github.com/apache/pulsar/pull/22983#discussion_r1666513004
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java:
##########
@@ -1034,4 +1040,88 @@ public void testConfigReplicationStartAt() throws
Exception {
admin1.topics().delete(topic3, false);
admin2.topics().delete(topic3, false);
}
+
+ @DataProvider(name = "replicationModes")
+ public Object[][] replicationModes() {
+ return new Object[][]{
+ {ReplicationMode.OneWay},
+ {ReplicationMode.DoubleWay}
+ };
+ }
+
+ protected enum ReplicationMode {
+ OneWay,
+ DoubleWay;
+ }
+
+ @Test(dataProvider = "replicationModes")
+ public void testDifferentTopicCreationRule(ReplicationMode
replicationMode) throws Exception {
+ String ns = defaultTenant + "/ns_2"/* +
UUID.randomUUID().toString().replace("-", "")*/;
Review Comment:
Why `UUID.randomUUID().toString().replace("-", "")` was commented out?
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationData.java:
##########
@@ -204,6 +204,8 @@ public class ProducerConfigurationData implements
Serializable, Cloneable {
private SortedMap<String, String> properties = new TreeMap<>();
+ private boolean forceOnoPartitioned;
Review Comment:
It is `forceOnePartitioned`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
