BewareMyPower commented on code in PR #1237:
URL: https://github.com/apache/pulsar-client-go/pull/1237#discussion_r1672145178
##########
pulsar/error.go:
##########
@@ -121,6 +121,15 @@ const (
// fenced. Applications are now supposed to close it and create a
// new producer
ProducerFenced
+ // MaxConcurrentOperationsReached indicates that the maximum number of
concurrent operations
+ // has been reached. This means that no additional operations can be
started until some
+ // of the current operations complete.
+ MaxConcurrentOperationsReached
+ // TransactionCoordinatorNotEnabled indicates that the transaction
coordinator is not enabled.
+ // This error is returned when an operation that requires the
transaction coordinator is attempted
+ // but the transaction coordinator feature is not enabled in the system
or the transaction coordinator
+ // has not initialized
+ TransactionCoordinatorNotEnabled
Review Comment:
These new error codes and related changes are also unrelated to this PR.
You'd better open a new PR for it.
That's also a disadvantage of such a huge PR because unrelated changes can
easily hide in the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
