TakaHiR07 commented on code in PR #22944:
URL: https://github.com/apache/pulsar/pull/22944#discussion_r1646335972
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1033,6 +1071,63 @@ private void checkForNewEntries(OpReadEntry op,
ReadEntriesCallback callback, Ob
}
}
+ private void checkForNewEntriesByMaxReadPosition(OpReadEntry op,
ReadEntriesCallback callback, Object ctx) {
+ try {
+ if (log.isDebugEnabled()) {
+ log.debug("[{}] [{}] Re-trying the read at readPosition {}
maxPosition {}",
+ ledger.getName(), name, op.readPosition,
op.maxPosition);
+ }
+
+ if (isClosed()) {
+ callback.readEntriesFailed(new
CursorAlreadyClosedException("Cursor was already closed"), ctx);
Review Comment:
I think so. need to recycle the op first. But this is better fixed by
another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
