poorbarcode commented on code in PR #23049:
URL: https://github.com/apache/pulsar/pull/23049#discussion_r1682310559
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1509,6 +1514,31 @@ public CompletableFuture<List<String>>
getListOfTopics(NamespaceName namespaceNa
}
}
+ public CompletableFuture<List<String>> getListOfUserTopics(NamespaceName
namespaceName, Mode mode) {
+ String key = String.format("%s://%s", mode, namespaceName);
+ CompletableFuture<List<String>> queryRes =
+ inProgressQueryUserTopics.computeIfAbsent(key, k -> {
+ CompletableFuture<List<String>> res = new CompletableFuture<>();
+ // Switch thread to avoid blocking other threads who are calling
the current method.
Review Comment:
> getListOfTopics is already an asynchronous operation that does not call
any blocking method. Why could it block other threads?
The steps as below
- async load topics if in cache. And if the res was conatined in the cache,
it will not switch thread.
- loop topics(there may be more than `10k` topics in this list)
- get `TopicName` object from cache(there may be more than `10k` topics in
the cache)
Once the topics is in the cache, it will block other threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
