gunli commented on code in PR #1247:
URL: https://github.com/apache/pulsar-client-go/pull/1247#discussion_r1683907429
##########
pulsar/producer_partition.go:
##########
@@ -863,13 +857,19 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
return
}
+ p.writeData(batchData, sequenceID, &callbacks)
+}
+
+func (p *partitionProducer) writeData(buffer internal.Buffer, sequenceID
uint64, callbacks *[]interface{}) {
Review Comment:
I think `[]interface{}` is better than `*[]interface{}`, in go, although the
parameter is passed by value, but if the parameter is a slice, it just copy
the value of the address of the underlying array, not the value of all the
elements in that array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
