poorbarcode commented on code in PR #23052:
URL: https://github.com/apache/pulsar/pull/23052#discussion_r1685921400
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/PulsarServiceTest.java:
##########
@@ -187,6 +192,34 @@ public void testDynamicBrokerPort() throws Exception {
assertEquals(pulsar.getWebServiceAddressTls(), "https://localhost:"; +
pulsar.getWebService().getListenPortHTTPS().get());
}
+ @Test
+ public void testTopicCacheConfiguration() throws Exception {
+ cleanup();
+ setup();
+ assertEquals(conf.getTopicNameCacheCaxCapacity(), 5000);
+ assertEquals(conf.getMaxSecondsToClearTopicNameCache(), 5);
+
+ List<TopicName> topicNameCached = new ArrayList<>();
+ for (int i = 0; i < 20; i++) {
+ topicNameCached.add(TopicName.get("public/default/tp_" + i));
+ }
+
+ // Verify: the cache does not clear since it is not larger than max
capacity.
+ Thread.sleep(10 * 1000);
+ for (int i = 0; i < 20; i++) {
+ assertTrue(topicNameCached.get(i) ==
TopicName.get("public/default/tp_" + i));
+ }
+
+ // Update max capacity.
+
admin.brokers().updateDynamicConfiguration("topicNameCacheCaxCapacity", "10");
+
+ // Verify: the cache were cleared.
+ Thread.sleep(10 * 1000);
+ for (int i = 0; i < 20; i++) {
+ assertFalse(topicNameCached.get(i) ==
TopicName.get("public/default/tp_" + i));
Review Comment:
No, it will load the second time if there is no value cached
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
