RobertIndie opened a new pull request, #23075:
URL: https://github.com/apache/pulsar/pull/23075
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
### Motivation
Currently, the lookup process uses only the topic name as its parameter.
However, to enhance this process, it's
beneficial for clients to provide additional information. This could be done
by introducing the `properties` field in
the client configuration. The client can then send these properties to the
broker during the lookup process.
Here is a scenario for using the client properties for the lookup:
Assuming there are two brokers that broker-0 configures the "rack" property
with "A" and broker-1 configures the "rack"
property with "B". By using the lookup properties, clients can supply rack
information during the lookup, enabling the
broker to identify and connect them to the nearest broker within the same
rack. If a client that configures the "rack"
property with "A" connects to a lookup broker, the customized load manager
can determine broker-0 as the owner broker
since the broker and the client have the same rack property.
### Modifications
Add new configuration `properties` to the client. While looking up the
broker, the client will send the properties to
the broker through `CommandLookupTopic` request.
The `properties` will be added to the `LookupOptions`. The Load Manager
implementation can retrieve the `properties`
through `LookupOptions` to make a better decision on which broker to return.
The properties are used only when the protocol is the binary protocol,
starting with `pulsar://` or `pulsar+ssl://`, or
if the `loadManagerClassName` in the broker is a class that implements the
`ExtensibleLoadManager` interface.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
