lhotari commented on code in PR #23078:
URL: https://github.com/apache/pulsar/pull/23078#discussion_r1695116720


##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumMongoDbContainer.java:
##########
@@ -25,7 +25,7 @@ public class DebeziumMongoDbContainer extends 
ChaosContainer<DebeziumMongoDbCont
     public static final String NAME = "debezium-mongodb-example";
 
     public static final Integer[] PORTS = { 27017 };
-    private static final String IMAGE_NAME = "debezium/example-mongodb:0.10";
+    private static final String IMAGE_NAME = 
"debezium/example-mongodb:2.5.0.Final";

Review Comment:
   Is there a specific reason to use 2.5.0.Final? Why not match the Debezium 
version?
   



##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumMySQLContainer.java:
##########
@@ -26,7 +26,7 @@ public class DebeziumMySQLContainer extends 
ChaosContainer<DebeziumMySQLContaine
     public static final String NAME = "debezium-mysql-example";
     static final Integer[] PORTS = { 3306 };
 
-    private static final String IMAGE_NAME = "debezium/example-mysql:0.8";
+    private static final String IMAGE_NAME = 
"debezium/example-mysql:2.5.0.Final";

Review Comment:
   Is there a specific reason to use 2.5.0.Final? Why not match the Debezium 
version?



##########
pom.xml:
##########
@@ -201,7 +201,7 @@ flexible messaging model and an intuitive client 
API.</description>
     <json-smart.version>2.4.10</json-smart.version>
     <opensearch.version>1.2.4</opensearch.version>
     <elasticsearch-java.version>8.12.1</elasticsearch-java.version>
-    <debezium.version>1.9.7.Final</debezium.version>
+    <debezium.version>2.6.1.Final</debezium.version>

Review Comment:
   According to https://debezium.io/ , latest stable Debezium release series is 
2.7.x . Could we upgrade directly to 2.7.x instead?



##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgreSqlContainer.java:
##########
@@ -26,7 +26,7 @@ public class DebeziumPostgreSqlContainer extends 
ChaosContainer<DebeziumPostgreS
     public static final String NAME = "debezium-postgresql-example";
     static final Integer[] PORTS = { 5432 };
 
-    private static final String IMAGE_NAME = "debezium/example-postgres:0.10";
+    private static final String IMAGE_NAME = 
"debezium/example-postgres:2.5.0.Final";

Review Comment:
   Is there a specific reason to use 2.5.0.Final? Why not match the Debezium 
version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to