BewareMyPower commented on code in PR #23119:
URL: https://github.com/apache/pulsar/pull/23119#discussion_r1703495255
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1342,7 +1342,11 @@ public void
addNamespaceBundleOwnershipListener(NamespaceBundleOwnershipListener
}
}
pulsar.runWhenReadyForIncomingRequests(() -> {
- getOwnedServiceUnits().forEach(bundle ->
notifyNamespaceBundleOwnershipListener(bundle, listeners));
+ try {
+ getOwnedServiceUnits().forEach(bundle ->
notifyNamespaceBundleOwnershipListener(bundle, listeners));
Review Comment:
I think we should process the possible exception from
`notifyNamespaceBundleOwnershipListener` as well. Currently, if one listener
fails, the following listeners will be skipped. We'd better catch the
`Throwable` for `notifyNamespaceBundleOwnershipListener` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
