onobc commented on PR #181: URL: https://github.com/apache/pulsar-client-reactive/pull/181#issuecomment-2278458977
> > There are 2 commits on purpose - please don't squash on commit. > > squashing is currently forced by `.asf.yaml` settings. We would have to modify > > https://github.com/apache/pulsar-client-reactive/blob/11b0de9a6169aaefe046b5426948fa5e0dceb5ee/.asf.yaml#L36-L42 > > to enable merging without squashing. > Docs for `.asf.yaml` are at https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#merge . We can change `.asf.yaml` for `pulsar-client-reactive` in a PR if we prefer to change the current settings. Oh no, thats fine. This is not that important to split into 2 separate commits. We can just squash. In fact I will do that now as I am going to back off the version bump in subsequent commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
