zymap commented on code in PR #23131:
URL: https://github.com/apache/pulsar/pull/23131#discussion_r1713099680
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java:
##########
@@ -108,6 +108,9 @@ private CompletableFuture<Optional<CacheGetResult<T>>>
readValueFromStore(String
try {
GetResult res = optRes.get();
+ if (res.getValue().length == 0) {
+ return FutureUtils.value(Optional.of(new
CacheGetResult<>(null, res.getStat())));
+ }
Review Comment:
@hangc0276 Thank you! I realized I was wrong to do this fix here because the
byte[0] may be a magic value for the SerDe implementation. It should be handled
in the SerDe classes. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
