(pulsar) branch branch-3.3 updated: [fix][broker] Fix 'Disabled replicated subscriptions controller' logic and logging (#23142)

[zixuan]

This is an automated email from the ASF dual-hosted git repository.

zixuan pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-3.3 by this push:
     new b2a469c6f6d [fix][broker] Fix 'Disabled replicated subscriptions 
controller' logic and logging (#23142)
b2a469c6f6d is described below

commit b2a469c6f6d58dbd4eb17728462c328715191149
Author: hanmz <gunn...@tencent.com>
AuthorDate: Tue Aug 13 11:06:01 2024 +0800

    [fix][broker] Fix 'Disabled replicated subscriptions controller' logic and 
logging (#23142)
    
    (cherry picked from commit 9bf714ff756b0729094e9a8611137d3dcfaed5b0)
---
 .../org/apache/pulsar/broker/service/persistent/PersistentTopic.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
index 0b07ea96d80..a45d690da6e 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
@@ -4047,8 +4047,8 @@ public class PersistentTopic extends AbstractTopic 
implements Topic, AddEntryCal
             log.info("[{}] Enabling replicated subscriptions controller", 
topic);
             replicatedSubscriptionsController = Optional.of(new 
ReplicatedSubscriptionsController(this,
                     
brokerService.pulsar().getConfiguration().getClusterName()));
-        } else if (isCurrentlyEnabled && !shouldBeEnabled || 
!isEnableReplicatedSubscriptions
-                || !replicationEnabled) {
+        } else if (isCurrentlyEnabled && (!shouldBeEnabled || 
!isEnableReplicatedSubscriptions
+                || !replicationEnabled)) {
             log.info("[{}] Disabled replicated subscriptions controller", 
topic);
             
replicatedSubscriptionsController.ifPresent(ReplicatedSubscriptionsController::close);
             replicatedSubscriptionsController = Optional.empty();