heesung-sn commented on code in PR #23167: URL: https://github.com/apache/pulsar/pull/23167#discussion_r1717154424
########## pip/pip-369.md: ########## @@ -0,0 +1,89 @@ +# PIP-371: Support to specify message listeners in TableView constructor + +# Background knowledge + +### TableView +Ref: https://pulsar.apache.org/docs/next/concepts-clients/#tableview + +### TableView Listeners +TableView runs the registered listeners on each received message. TableView users could utilize TableView Listeners for event-sourcing applications. + +### How to Register TableView Listeners + +Currently, `TableView#foreachAndListen` and `TableView#listen` interfaces are used to register listeners. + +# Motivation +issue : https://github.com/apache/pulsar/issues/23158 + +As reported in the above issue, currently, the TableView listener registration methods, `foreachAndListen` and `listen`, are being called after `TableView#start()`. This timing issue can result in some messages being missed or not handled if the listeners are registered too late. + +Additionally, the current implementation of these listeners does not distinguish between existing messages (those present before the TableView started) and tail (future) messages (those received after the TableView started). Some business logic may require different handling for these two types of messages, but the current design does not support this differentiation. + + + +# Goals + +## In Scope + +- Support specifying TableView Listeners in TableView builder and constructor, so that TableView can register listeners as part of instance init and accordingly call them for all messages. +- Support specifying TableView Listeners for existing and tail messages separately. +- This design is based on Pulsar-Java-Client. + +# Detailed Design + +## Design & Implementation Details + +Add followings in TableViewBuilder.java +```java + /** + * Set the message listeners. + * If {@link TableViewBuilder#existingMessageListeners} are not specified, + * these listeners are used for both + * existing and tailing(future) messages in the topic. Review Comment: Alternatively, we can introduce an enum TableViewMessageType{ Existing, Tail } And expose this Api only TableViewBuilder<T> messageListeners(TableViewMessageType type, BiConsumer<String, T>... listeners) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
