hrsakai opened a new pull request, #23174:
URL: https://github.com/apache/pulsar/pull/23174

   ### Motivation
   
   * jackson-1.14.2 has the vulnerability.
    https://security.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-7569538
   *  `@JsonIgnore` in latest version of jackson works well.
     https://github.com/apache/pulsar/pull/20182
     
https://github.com/FasterXML/jackson-databind/commit/4537f09d3419440554c7cf6f2d8130205fc6be6e
   
   I run the following code:
   <details>
     <summary>JsonIgnore test code</summary>
   
   ```
   class Foo {
       private int a = 10;
   
       @JsonIgnore
       private transient int b = 11;
   
       public int getA() {
           return a;
       }
   
       public void setA(int a) {
           this.a = a;
       }
   
       public int getB() {
           return b;
       }
   
       public void setB(int b) {
           this.b = b;
       }
   
       public static void main(String args[]) throws JsonProcessingException {
           ObjectMapper ob = new ObjectMapper();
           System.out.println(ob.writeValueAsString(new Foo()));
       }
   }
   ```
   </details>
   
   result:
   ```
   # expected
    {"a":10}
   
   # 2.14.2
   {"a":10}
   
   # 2.15.2
   {"a":10,"b":11}
   
   # 2.17.2
   {"a":10}
   ```
   
   ### Modifications
   
   * Upgrade jackson to 2.17.2
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions 
will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since 
the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed 
in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments 
have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to