lhotari opened a new pull request, #23178:
URL: https://github.com/apache/pulsar/pull/23178

   Fixes #23176
   
   ### Motivation
   
   The way RocksDB is configured changed in Pulsar 2.11 / Bookkeeper 4.15 .
   The settings are handled in `conf/entry_location_rocksdb.conf` file and 
`dbStorage_rocksDB_*` keys in bookkeeper.conf have no effect. This is mainly a 
problem for Kubernetes deployments since there's not an easy way to override 
the configs.
   
   ### Modifications
   
   - add generics script `update-ini-from-env.py` for updating keys in RocksDB 
ini files by environment variables
   - add compatibility script `update-rocksdb-conf-from-env.py` for updating 
`conf/entry_location_rocksdb.conf` file with `dbStorage_rocksDB_*` keys in the 
environment.
   
   ### Additional context
   
   With these changes, it's possible to modify a Pulsar Helm chart's 
bookkeeper/autorecovery commands to include `&& (([ -x 
bin/update-rocksdb-conf-from-env.py ] && bin/update-rocksdb-conf-from-env.py) 
|| true)` after `bin/apply-config-from-env.py conf/bookkeeper.conf`
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to