codecov-commenter commented on PR #23110: URL: https://github.com/apache/pulsar/pull/23110#issuecomment-2298190351
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23110?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `85.21971%` with `111 lines` in your changes missing coverage. Please review. > Project coverage is 74.55%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`dde4770`)](https://app.codecov.io/gh/apache/pulsar/commit/dde477040b487bf4b693a7b4030bc9161d07cf14?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 533 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/23110?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...he/pulsar/common/util/DefaultPulsarSslFactory.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Futil%2FDefaultPulsarSslFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi91dGlsL0RlZmF1bHRQdWxzYXJTc2xGYWN0b3J5LmphdmE=) | 81.98% | [21 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../apache/pulsar/proxy/server/AdminProxyHandler.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fproxy%2Fserver%2FAdminProxyHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL0FkbWluUHJveHlIYW5kbGVyLmphdmE=) | 79.62% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/pulsar/broker/service/BrokerService.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2FBrokerService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Jyb2tlclNlcnZpY2UuamF2YQ==) | 61.11% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/pulsar/client/impl/HttpClient.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FHttpClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0h0dHBDbGllbnQuamF2YQ==) | 83.72% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ulsar/broker/service/PulsarChannelInitializer.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2FPulsarChannelInitializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1B1bHNhckNoYW5uZWxJbml0aWFsaXplci5qYXZh) | 81.81% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/pulsar/broker/web/WebService.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fweb%2FWebService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci93ZWIvV2ViU2VydmljZS5qYXZh) | 85.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/pulsar/functions/worker/rest/WorkerServer.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-functions%2Fworker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Ffunctions%2Fworker%2Frest%2FWorkerServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWZ1bmN0aW9ucy93b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9mdW5jdGlvbnMvd29ya2VyL3Jlc3QvV29ya2VyU2VydmVyLmphdmE=) | 84.61% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pulsar/proxy/server/ServiceChannelInitializer.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fproxy%2Fserver%2FServiceChannelInitializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL1NlcnZpY2VDaGFubmVsSW5pdGlhbGl6ZXIuamF2YQ==) | 83.78% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/pulsar/proxy/server/WebServer.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fproxy%2Fserver%2FWebServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL1dlYlNlcnZlci5qYXZh) | 85.71% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/pulsar/websocket/service/ProxyServer.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-websocket%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fwebsocket%2Fservice%2FProxyServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9zZXJ2aWNlL1Byb3h5U2VydmVyLmphdmE=) | 84.61% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [8 more](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #23110 +/- ## ============================================ + Coverage 73.57% 74.55% +0.98% - Complexity 32624 33706 +1082 ============================================ Files 1877 1918 +41 Lines 139502 144717 +5215 Branches 15299 15819 +520 ============================================ + Hits 102638 107894 +5256 + Misses 28908 28581 -327 - Partials 7956 8242 +286 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23110/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23110/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.69% <52.86%> (+3.11%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/23110/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.66% <4.52%> (+0.33%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23110/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.91% <85.21%> (+1.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/23110?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...org/apache/pulsar/broker/ServiceConfiguration.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2FServiceConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `99.03% <100.00%> (-0.36%)` | :arrow_down: | | [...pache/pulsar/jetty/tls/JettySslContextFactory.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fjetty%2Ftls%2FJettySslContextFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9qZXR0eS90bHMvSmV0dHlTc2xDb250ZXh0RmFjdG9yeS5qYXZh) | `90.00% <100.00%> (-1.31%)` | :arrow_down: | | [...n/java/org/apache/pulsar/broker/PulsarService.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2FPulsarService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9QdWxzYXJTZXJ2aWNlLmphdmE=) | `84.45% <100.00%> (+2.08%)` | :arrow_up: | | [...va/org/apache/pulsar/compaction/CompactorTool.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcompaction%2FCompactorTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbXBhY3Rpb24vQ29tcGFjdG9yVG9vbC5qYXZh) | `69.73% <100.00%> (+0.81%)` | :arrow_up: | | [...pache/pulsar/common/policies/data/ClusterData.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client-admin-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Fpolicies%2Fdata%2FClusterData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hZG1pbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jb21tb24vcG9saWNpZXMvZGF0YS9DbHVzdGVyRGF0YS5qYXZh) | `100.00% <ø> (ø)` | | | [...a/org/apache/pulsar/admin/cli/PulsarAdminTool.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client-tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fadmin%2Fcli%2FPulsarAdminTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9QdWxzYXJBZG1pblRvb2wuamF2YQ==) | `90.47% <100.00%> (+3.70%)` | :arrow_up: | | [...org/apache/pulsar/client/cli/PulsarClientTool.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client-tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fcli%2FPulsarClientTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9jbGkvUHVsc2FyQ2xpZW50VG9vbC5qYXZh) | `79.43% <100.00%> (+10.98%)` | :arrow_up: | | [...g/apache/pulsar/client/impl/ClientBuilderImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FClientBuilderImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NsaWVudEJ1aWxkZXJJbXBsLmphdmE=) | `86.82% <100.00%> (+0.83%)` | :arrow_up: | | [.../org/apache/pulsar/client/impl/ConnectionPool.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FConnectionPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0Nvbm5lY3Rpb25Qb29sLmphdmE=) | `76.44% <100.00%> (+1.92%)` | :arrow_up: | | [...rg/apache/pulsar/client/impl/PulsarClientImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudEltcGwuamF2YQ==) | `75.55% <100.00%> (+1.24%)` | :arrow_up: | | ... and [24 more](https://app.codecov.io/gh/apache/pulsar/pull/23110?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [486 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23110/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
