hangc0276 commented on code in PR #23204:
URL: https://github.com/apache/pulsar/pull/23204#discussion_r1723027787
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -683,12 +683,8 @@ public void updateSubscribeRateLimiter() {
}
private void asyncAddEntry(ByteBuf headersAndPayload, PublishContext
publishContext) {
- if (brokerService.isBrokerEntryMetadataEnabled()) {
- ledger.asyncAddEntry(headersAndPayload,
- (int) publishContext.getNumberOfMessages(), this,
publishContext);
- } else {
- ledger.asyncAddEntry(headersAndPayload, this, publishContext);
- }
+ ledger.asyncAddEntry(headersAndPayload,
Review Comment:
You also need to handle publish Txn messages
https://github.com/apache/pulsar/blob/2d46bfafab2567593067847775b2d672ed502144/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L4236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
