poorbarcode commented on code in PR #23169:
URL: https://github.com/apache/pulsar/pull/23169#discussion_r1723164163
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -609,11 +609,15 @@ protected void
internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
.thenCompose(__ ->
provisionPartitionedTopicPath(numPartitions, createLocalTopicOnly, properties))
.thenCompose(__ -> tryCreatePartitionsAsync(numPartitions))
.thenRun(() -> {
- if (!createLocalTopicOnly && topicName.isGlobal()) {
+ if (!createLocalTopicOnly && topicName.isGlobal()
+ &&
pulsar().getConfig().isCreateTopicToRemoteClusterForReplication()) {
internalCreatePartitionedTopicToReplicatedClustersInBackground(numPartitions);
+ log.info("[{}] Successfully created partitions for
topic {} for the remote clusters {}",
Review Comment:
Since we can hardly get remote clusters here, I removed the part of the log
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -609,11 +609,15 @@ protected void
internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
.thenCompose(__ ->
provisionPartitionedTopicPath(numPartitions, createLocalTopicOnly, properties))
.thenCompose(__ -> tryCreatePartitionsAsync(numPartitions))
.thenRun(() -> {
- if (!createLocalTopicOnly && topicName.isGlobal()) {
+ if (!createLocalTopicOnly && topicName.isGlobal()
+ &&
pulsar().getConfig().isCreateTopicToRemoteClusterForReplication()) {
internalCreatePartitionedTopicToReplicatedClustersInBackground(numPartitions);
+ log.info("[{}] Successfully created partitions for
topic {} for the remote clusters {}",
+ clientAppId(), topicName,
pulsar().getConfiguration().getClusterName());
+ } else {
+ log.info("[{}] Skip creating partitions for topic {}
for the remote clusters {}",
Review Comment:
Since we can hardly get remote clusters here, I removed the part of the log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
