(pulsar) 01/02: [improve][broker] Improve pulsar_topic_load_failed metric to record correct failed time (#23199)

[lhotari]

This is an automated email from the ASF dual-hosted git repository.

lhotari pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit 35ca6ebe3b7c3d6490d416642b71c5570f05ae3f
Author: ken <1647023...@qq.com>
AuthorDate: Wed Aug 21 11:06:35 2024 +0800

    [improve][broker] Improve pulsar_topic_load_failed metric to record correct 
failed time (#23199)
    
    Co-authored-by: fanjianye <fanjia...@bigo.sg>
    (cherry picked from commit b661ec82d20adb71c0fe00ad115ec1ab71327880)
---
 .../java/org/apache/pulsar/broker/service/BrokerService.java   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
index 7d3c893baa9..c4c2ae63bad 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
@@ -1551,6 +1551,11 @@ public class BrokerService implements Closeable {
                 
Duration.ofSeconds(pulsar.getConfiguration().getTopicLoadTimeoutSeconds()), 
executor(),
                 () -> FAILED_TO_LOAD_TOPIC_TIMEOUT_EXCEPTION);
 
+        topicFuture.exceptionally(t -> {
+            pulsarStats.recordTopicLoadFailed();
+            return null;
+        });
+
         checkTopicNsOwnership(topic)
                 .thenRun(() -> {
                     final Semaphore topicLoadSemaphore = 
topicLoadRequestSemaphore.get();
@@ -1665,11 +1670,6 @@ public class BrokerService implements Closeable {
         TopicName topicName = TopicName.get(topic);
         final long topicCreateTimeMs = 
TimeUnit.NANOSECONDS.toMillis(System.nanoTime());
 
-        topicFuture.exceptionally(t -> {
-            pulsarStats.recordTopicLoadFailed();
-            return null;
-        });
-
         if (isTransactionInternalName(topicName)) {
             String msg = String.format("Can not create transaction system 
topic %s", topic);
             log.warn(msg);