ocadaruma commented on PR #23216: URL: https://github.com/apache/pulsar/pull/23216#issuecomment-2308575459
Hi, the change looks make sense. For `ConcurrentOpenHashSet`, how about replacing type declarations with `Set` and use `ConcurrentHashMap.newKeySet()` ? To express the `Set` type, it's more straightforward than `ConcurrentHashMap<T, Boolean>` and helps the reader IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
