RobertIndie commented on code in PR #1271:
URL: https://github.com/apache/pulsar-client-go/pull/1271#discussion_r1730994182
##########
pulsaradmin/pkg/admin/namespace.go:
##########
@@ -114,6 +114,12 @@ type Namespaces interface {
// GetOffloadThreshold returns the offloadThreshold for a namespace
GetOffloadThreshold(namespace utils.NameSpaceName) (int64, error)
+ // SetOffloadThreshold sets the offloadThresholdInSeconds for a
namespace
Review Comment:
```suggestion
// SetOffloadThresholdInSeconds sets the offloadThresholdInSeconds for
a namespace
```
##########
pulsaradmin/pkg/admin/namespace.go:
##########
@@ -114,6 +114,12 @@ type Namespaces interface {
// GetOffloadThreshold returns the offloadThreshold for a namespace
GetOffloadThreshold(namespace utils.NameSpaceName) (int64, error)
+ // SetOffloadThreshold sets the offloadThresholdInSeconds for a
namespace
+ SetOffloadThresholdInSeconds(namespace utils.NameSpaceName, threshold
int64) error
+
+ // GetOffloadThreshold returns the offloadThresholdInSeconds for a
namespace
Review Comment:
```suggestion
// GetOffloadThresholdInSeconds returns the offloadThresholdInSeconds
for a namespace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
