lhotari commented on code in PR #23222: URL: https://github.com/apache/pulsar/pull/23222#discussion_r1732805639
########## pip/pip-375.md: ########## @@ -0,0 +1,32 @@ +# PIP-375: Expose the Admin client configs: readTimeout, requestTimeout, connectionTimeout + +# Background knowledge + +- `pulsar-admin sinks create` will upload files to brokers, but if the file is large and the network is slow, it may cost a long time. +- The default value of `requestTimeout` of Admin API is `60s`, after the fix https://github.com/apache/pulsar/pull/23128, it was changed to `300s`. Review Comment: > The default value of `requestTimeout` is `300s` and the default value of `readTimeout` is `60s`, @poorbarcode Did I understand this sentence correct that requestTimeout is set to the default value of 300s somewhere in the Pulsar code base? I was looking for that code location. ########## pip/pip-375.md: ########## @@ -0,0 +1,32 @@ +# PIP-375: Expose the Admin client configs: readTimeout, requestTimeout, connectionTimeout + +# Background knowledge + +- `pulsar-admin sinks create` will upload files to brokers, but if the file is large and the network is slow, it may cost a long time. +- The default value of `requestTimeout` of Admin API is `60s`, after the fix https://github.com/apache/pulsar/pull/23128, it was changed to `300s`. Review Comment: > The default value of `requestTimeout` is `300s` and the default value of `readTimeout` is `60s`, @poorbarcode Did I understand this sentence correctly that requestTimeout is set to the default value of 300s somewhere in the Pulsar code base? I was looking for that code location. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
