RobertIndie commented on code in PR #23236:
URL: https://github.com/apache/pulsar/pull/23236#discussion_r1740725766
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java:
##########
@@ -239,7 +239,8 @@ public void run() {
ManagedLedgerImpl.TOTAL_SIZE_UPDATER.addAndGet(ml, dataLength);
long ledgerId = ledger != null ? ledger.getId() : ((Position)
ctx).getLedgerId();
- if (ml.hasActiveCursors()) {
+ // Don't insert to the entry cache for the ShadowManagedLedger
+ if (!(ml instanceof ShadowManagedLedgerImpl) && ml.hasActiveCursors())
{
Review Comment:
Good suggestion. Applied it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
