lhotari commented on PR #23231: URL: https://github.com/apache/pulsar/pull/23231#issuecomment-2325287796
> One of the details that I'll have to address is the fact that the Pulsar client consumer sends permits for entries/batches and not individual messages. This detail isn't accurately described in the [Pulsar binary protocol specification](https://pulsar.apache.org/docs/next/developing-binary-protocol/#consumer). I noticed that the calculations based on available permits and available unacknowledged messages were wrong for both Shared and Key_Shared subscriptions. The fixes are included in this PR for both subscription types. Tests break unless the fixes are made for Key_Shared subscriptions and since the fix is made for Key_Shared, it should also be applied for Shared subscriptions. This does show a lack of proper test coverage to catch regressions in this area so it's not the most optimal solution to roll the changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
