rdhabalia commented on code in PR #23256:
URL: https://github.com/apache/pulsar/pull/23256#discussion_r1744885413
##########
pulsar-client-messagecrypto-bc/src/main/java/org/apache/pulsar/client/impl/crypto/MessageCryptoBc.java:
##########
@@ -525,6 +525,10 @@ private boolean decryptDataKey(String keyName, byte[]
encryptedDataKey, List<Key
| NoSuchPaddingException | InvalidKeyException |
InvalidAlgorithmParameterException e) {
log.error("{} Failed to decrypt data key {} to decrypt messages
{}", logCtx, keyName, e.getMessage());
return false;
+ } catch (Exception e) {
Review Comment:
we can't merge `Exception` with other checked exceptions. but we can remove
other catch block and just keep the `Exception` catch block because anyway, we
are not doing any special handling with other checked-type exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
