hanmz commented on code in PR #23259:
URL: https://github.com/apache/pulsar/pull/23259#discussion_r1746514685
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/GetPartitionMetadataMultiBrokerTest.java:
##########
@@ -256,8 +256,8 @@ public void
testCompatibilityDifferentBrokersForNonPersistentTopic(boolean confi
// Initialize the connections of internal Pulsar Client.
PulsarClientImpl client1 = (PulsarClientImpl) pulsar1.getClient();
PulsarClientImpl client2 = (PulsarClientImpl) pulsar2.getClient();
-
client1.getLookup(pulsar2.getBrokerServiceUrl()).getBroker(TopicName.get(DEFAULT_NS
+ "/tp1"));
-
client2.getLookup(pulsar1.getBrokerServiceUrl()).getBroker(TopicName.get(DEFAULT_NS
+ "/tp1"));
+
client1.getLookup(pulsar2.getBrokerServiceUrl()).getBroker(TopicName.get(DEFAULT_NS
+ "/tp1")).join();
+
client2.getLookup(pulsar1.getBrokerServiceUrl()).getBroker(TopicName.get(DEFAULT_NS
+ "/tp1")).join();
Review Comment:
Since the pulsar client itself has a timeout set, is it necessary to add
additional timeouts here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
