KennyChenFight commented on PR #1277: URL: https://github.com/apache/pulsar-client-go/pull/1277#issuecomment-2335051805
> > the messages added to ack_grouping_tracker are considered ready to be acknowledged. > > You can create a map to record the batch message, such as `batchMessagePendingAcks map[[2]uint64]*batchMessageTracker`. > > > However, if we record the batch index here, it means that adding a message does not necessarily mean it can be acknowledged, which might be a bit strange. > > Only record the ledger ID and entry ID. > > > Or perhaps we need to move this part: ... to `ack_grouping_tracker` as well? > > Sounds good! Sounds good! Let me try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
