Denovo1998 commented on code in PR #6: URL: https://github.com/apache/pulsar-java-contrib/pull/6#discussion_r1750283332
########## pulsar-rpc-contrib/src/main/java/org/apache/pulsar/rpc/contrib/client/PulsarRpcClient.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.pulsar.rpc.contrib.client; + +import static lombok.AccessLevel.PACKAGE; +import java.io.IOException; +import java.time.Duration; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.TimeUnit; +import lombok.Getter; +import lombok.NonNull; +import lombok.RequiredArgsConstructor; +import org.apache.pulsar.client.api.Consumer; +import org.apache.pulsar.client.api.Producer; +import org.apache.pulsar.client.api.PulsarClient; +import org.apache.pulsar.client.api.PulsarClientException; +import org.apache.pulsar.client.api.Schema; +import org.apache.pulsar.client.api.TypedMessageBuilder; +import org.apache.pulsar.rpc.contrib.common.MessageDispatcherFactory; + +/** + * Provides the functionality to send asynchronous requests and handle replies using Apache Pulsar as the + * messaging system. This client manages request-response interactions ensuring that messages are sent + * to the correct topics and handling responses through callbacks. + * + * @param <T> The type of the request messages. + * @param <V> The type of the reply messages. + */ +@RequiredArgsConstructor(access = PACKAGE) +public class PulsarRpcClient<T, V> implements AutoCloseable { Review Comment: Maybe same as https://github.com/apache/pulsar-java-contrib/pull/6#discussion_r1749516258 PulsarRpcClient, PulsarRpcClientImpl, PulsarRpcClientBuilder, PulsarRpcClientBuilderImpl Already added. PTAL! If this method is correct, I will modify the server code later. ########## pulsar-rpc-contrib/src/main/java/org/apache/pulsar/rpc/contrib/client/PulsarRpcClient.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.pulsar.rpc.contrib.client; + +import static lombok.AccessLevel.PACKAGE; +import java.io.IOException; +import java.time.Duration; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.TimeUnit; +import lombok.Getter; +import lombok.NonNull; +import lombok.RequiredArgsConstructor; +import org.apache.pulsar.client.api.Consumer; +import org.apache.pulsar.client.api.Producer; +import org.apache.pulsar.client.api.PulsarClient; +import org.apache.pulsar.client.api.PulsarClientException; +import org.apache.pulsar.client.api.Schema; +import org.apache.pulsar.client.api.TypedMessageBuilder; +import org.apache.pulsar.rpc.contrib.common.MessageDispatcherFactory; + +/** + * Provides the functionality to send asynchronous requests and handle replies using Apache Pulsar as the + * messaging system. This client manages request-response interactions ensuring that messages are sent + * to the correct topics and handling responses through callbacks. + * + * @param <T> The type of the request messages. + * @param <V> The type of the reply messages. + */ +@RequiredArgsConstructor(access = PACKAGE) +public class PulsarRpcClient<T, V> implements AutoCloseable { + private final ConcurrentHashMap<String, CompletableFuture<V>> pendingRequestsMap; + private final Duration replyTimeout; + private final RequestSender<T> sender; + @Getter + private final Producer<T> requestProducer; + private final Consumer<V> replyConsumer; + private final RequestCallBack<V> callback; + + /** + * Creates a new instance of {@link PulsarRpcClient} using the specified builder settings. + * + * @param client The Pulsar client to use for creating producers and consumers. + * @param builder The builder containing configurations for the client. + * @return A new instance of {@link PulsarRpcClient}. + * @throws IOException if there is an error during the client initialization. + */ + public static <T, V> PulsarRpcClient<T, V> create( Review Comment: Maybe same as https://github.com/apache/pulsar-java-contrib/pull/6#discussion_r1750283332 PulsarRpcClient, PulsarRpcClientImpl, PulsarRpcClientBuilder, PulsarRpcClientBuilderImpl Already added. PTAL! If this method is correct, I will modify the server code later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
