sandeep-mst commented on PR #22522: URL: https://github.com/apache/pulsar/pull/22522#issuecomment-2345409278
> > I like this idea. > > > > 1. I think we should register the new commands like other commands in `registerProviders(..)` so automatic autocompletion will work for these modes too. > > 2. I don't understand the title, what do you mean by persistent modes ? I think we need a better name for this feature. > > 3. We should add docs, at least in the help (might be mitigated by 1.) > > @sandeep-mst Have you considered addressing @nicoloboschi's review feedback? For number 2 point, calling it a "subcontext" would be perhaps better unless that concept carries already a different meaning. > > For example, [windows netsh has the concept of contexts and subcontexts](https://learn.microsoft.com/en-us/windows-server/networking/technologies/netsh/netsh-contexts#netsh-subcontexts) (top level is "context", which could have "subcontexts"). Hi @lhotari, 1. I have addressed the @nicoloboschi review feedback for supporting auto-completion for shell modes for `admin` and `client`. I removed `config` from the provided shell modes. > I tried to implement `config` shell mode even though it was not requested in the issue. I was facing lot of issues with it because `config` is stateful and implementation might require major changes to support auto-completion. 2. On the PR naming, context is already being used by [window-functions-context](https://pulsar.apache.org/docs/3.3.x/window-functions-context/) of pulsar. We could still use it. Please, let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
