jiazhai commented on a change in pull request #4866: [Transaction][buffer] Add
new commands for the transaction
URL: https://github.com/apache/pulsar/pull/4866#discussion_r310425995
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -573,144 +586,282 @@ message CommandGetTopicsOfNamespace {
NON_PERSISTENT = 1;
ALL = 2;
}
- required uint64 request_id = 1;
- required string namespace = 2;
+ required uint64 request_id = 1;
+ required string namespace = 2;
optional Mode mode = 3 [default = PERSISTENT];
}
message CommandGetTopicsOfNamespaceResponse {
- required uint64 request_id = 1;
- repeated string topics = 2;
+ required uint64 request_id = 1;
+ repeated string topics = 2;
}
message CommandGetSchema {
- required uint64 request_id = 1;
- required string topic = 2;
+ required uint64 request_id = 1;
+ required string topic = 2;
- optional bytes schema_version = 3;
+ optional bytes schema_version = 3;
}
message CommandGetSchemaResponse {
- required uint64 request_id = 1;
- optional ServerError error_code = 2;
+ required uint64 request_id = 1;
+ optional ServerError error_code = 2;
optional string error_message = 3;
- optional Schema schema = 4;
- optional bytes schema_version = 5;
+ optional Schema schema = 4;
+ optional bytes schema_version = 5;
+}
+
+/// --- transaction related ---
+
+enum TxnAction {
+ COMMIT = 0;
+ ABORT = 1;
+}
+
+message CommandNewTxn {
+ required uint64 request_id = 1;
+ optional uint64 txn_ttl_seconds = 2 [default = 0];
+}
+
+message CommandNewTxnResponse {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional ServerError error = 4;
+ optional string message = 5;
+}
+
+message CommandAddPartitionToTxn {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ repeated string partitions = 4;
+}
+
+message CommandAddPartitionToTxnResponse {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional ServerError error = 4;
+ optional string message = 5;
+}
+
+message Subscription {
+ required string topic = 1;
+ required string subscription = 2;
+}
+message CommandAddSubscriptionToTxn {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ repeated Subscription subscription = 4;
+}
+
+message CommandAddSubscriptionToTxnResponse {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional ServerError error = 4;
+ optional string message = 5;
+}
+
+message CommandEndTxn {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional TxnAction txn_action = 4;
+}
+
+message CommandEndTxnResponse {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional ServerError error = 4;
+ optional string message = 5;
+}
+
+message CommandEndTxnOnPartition {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional string topic = 4;
+ optional TxnAction txn_action = 5;
+}
+
+message CommandEndTxnOnPartitionResponse {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional ServerError error = 4;
+ optional string message = 5;
+}
+
+message CommandEndTxnOnSubscription {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional Subscription subscription= 4;
+ optional TxnAction txn_action = 5;
+}
+
+message CommandEndTxnOnSubscriptionResponse {
+ required uint64 request_id = 1;
+ optional uint64 txnid_least_bits = 2 [default = 0];
+ optional uint64 txnid_most_bits = 3 [default = 0];
+ optional ServerError error = 4;
+ optional string message = 5;
Review comment:
What message will return for all these Response above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
