lhotari commented on PR #21657: URL: https://github.com/apache/pulsar/pull/21657#issuecomment-2352205297
The problem that this PR is addressing will be covered in [PIP-379: Key_Shared Draining Hashes for Improved Message Ordering](https://github.com/apache/pulsar/pull/23309). To address this issue, I'll update PIP-379 so that the updated contract will cover how negative acknowledgements and explicit redeliveries such as `redeliverUnacknowledgedMessages` are handled in Key_Shared in the updated design. Currently it's not properly documented what happens when an application uses those methods when a Key_Shared subscription is used. If an application uses "nacks", it should either fail with an exception or there should be a clearly defined behavior. Since failing with an exception on the client side isn't a real option, the remaining option is to clearly define the behavior and make it consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
