(pulsar) branch master updated: [fix][test] Fix flaky test LeaderElectionTest.revalidateLeaderWithinSameSession (#22383)

[lhotari]

This is an automated email from the ASF dual-hosted git repository.

lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 216b83008de [fix][test] Fix flaky test 
LeaderElectionTest.revalidateLeaderWithinSameSession (#22383)
216b83008de is described below

commit 216b83008deb469e0fc55ed8117f0c393ebcb0ac
Author: maheshnikam <55378196+nika...@users.noreply.github.com>
AuthorDate: Mon Sep 23 14:17:31 2024 +0530

    [fix][test] Fix flaky test 
LeaderElectionTest.revalidateLeaderWithinSameSession (#22383)
---
 .../src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java  | 2 +-
 .../test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java  | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java
 
b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java
index 8e153b23d30..4af712d3357 100644
--- 
a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java
+++ 
b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java
@@ -59,7 +59,7 @@ public interface MetadataCache<T> {
      *
      * @param path
      *            the path of the object in the metadata store
-     * @return the cached object or an empty {@link Optional} is the cache 
doesn't have the object
+     * @return the cached object or an empty {@link Optional} is the cache 
does not have the object
      */
     Optional<T> getIfCached(String path);
 
diff --git 
a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java
 
b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java
index c77de92ae3c..d0265e3ca44 100644
--- 
a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java
+++ 
b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java
@@ -145,10 +145,11 @@ public abstract class BaseMetadataStoreTest extends 
TestRetrySupport {
                                             int retryCount,
                                             long intSleepTimeInMillis) throws 
Exception {
         assertTrue(retryStrategically((__) -> {
-            if (actual.get().equals(expectedAndRetry)) {
+            Object actualObject = actual.get();
+            if (actualObject.equals(expectedAndRetry)) {
                 return false;
             }
-            assertEquals(actual.get(), expected);
+            assertEquals(actualObject, expected);
             return true;
         }, retryCount, intSleepTimeInMillis));
     }