lhotari commented on PR #23231: URL: https://github.com/apache/pulsar/pull/23231#issuecomment-2371629067
I'm sorry @poorbarcode. Please let me explain the misunderstanding. > 5 days ago: you dismissed the Request Change, and left a comment: "Outdated comment" For me, the "request for changes" comment was "Please do not merge this PR fast, I will finish my review tomorrow" (https://github.com/apache/pulsar/pull/23231#pullrequestreview-2283712399). That's why I dismissed it with "Outdated comment". I had already addressed also the other review comments you had made. > Between `step-2` and `step-3`, you never marked it as available to review and never ask to review again, then you merged the PR 😂 I'm sorry for that. I did request a review, but you didn't respond. You can check the timeline. The PR was in draft mode for some time, but the reason for that was that the PR was already approved and I didn't want anyone to merge it. I didn't realize that you wouldn't be reviewing it because of the draft status. The changes in this PR aren't final, if you have review feedback, it's possible also address that after the PR has been merged. Please add comments to this PR of any concerns you may have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
