Technoboy- commented on code in PR #23305:
URL: https://github.com/apache/pulsar/pull/23305#discussion_r1774305836
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1157,7 +1158,8 @@ private CompletableFuture<? extends Subscription>
getNonDurableSubscription(Stri
long entryId = msgId.getEntryId();
// Ensure that the start message id starts from a valid entry.
if (ledgerId >= 0 && entryId >= 0
- && msgId instanceof BatchMessageIdImpl) {
+ && msgId instanceof BatchMessageIdImpl
+ && (msgId.getBatchIndex() >= 0 || resetIncludeHead)) {
Review Comment:
Adding `resetIncludeHead` should start a PIP. right now, we can only fix by
adding `msgId.getBatchIndex() >= 0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
