Technoboy- commented on code in PR #23345:
URL: https://github.com/apache/pulsar/pull/23345#discussion_r1776191326
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -1161,25 +1161,16 @@ private void executeKeySharedMessageListener(Message<?>
message, Runnable runnab
executorProvider.getExecutor(peekMessageKey(message)).execute(runnable);
}
+ protected void callMessageListenerAndIncreasePermits(Message<T> msg) {
+ if (log.isDebugEnabled()) {
+ log.debug("[{}][{}] Calling message listener for message {}",
topic, subscription, msg.getMessageId());
+ }
+ increasePermits(msg);
+ callMessageListener(msg);
+ }
+
protected void callMessageListener(Message<T> msg) {
try {
- if (log.isDebugEnabled()) {
Review Comment:
What's the main fix there? only split this method into `increasePermits` and
`callMessageListener`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
