This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 4d6dee456ca [fix][ml] Remove unnecessary return in ManagedLedgerImpl
(#23418)
4d6dee456ca is described below
commit 4d6dee456ca3c255d00d313995f7c1f9e78420f1
Author: Jiawen Wang <[email protected]>
AuthorDate: Wed Oct 9 02:52:47 2024 +0800
[fix][ml] Remove unnecessary return in ManagedLedgerImpl (#23418)
---
.../java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java | 7 -------
1 file changed, 7 deletions(-)
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index cb19bd94bce..c1081761b60 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -2229,13 +2229,11 @@ public class ManagedLedgerImpl implements
ManagedLedger, CreateCallback {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntryComplete(entry, cbCtx);
- return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}",
name, ledgerId, entryId);
}
entry.release();
- return;
}
}
@@ -2246,7 +2244,6 @@ public class ManagedLedgerImpl implements ManagedLedger,
CreateCallback {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntryFailed(exception, cbCtx);
- return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}",
name, ledgerId, entryId);
@@ -2261,13 +2258,11 @@ public class ManagedLedgerImpl implements
ManagedLedger, CreateCallback {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntriesComplete(returnedEntries, cbCtx);
- return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}",
name, ledgerId, entryId);
}
returnedEntries.forEach(Entry::release);
- return;
}
}
@@ -2278,12 +2273,10 @@ public class ManagedLedgerImpl implements
ManagedLedger, CreateCallback {
Object cbCtx = this.cntx;
if (recycle(reOpCount)) {
callback.readEntriesFailed(exception, cbCtx);
- return;
} else {
if (log.isDebugEnabled()) {
log.debug("[{}] read entry already completed for {}-{}",
name, ledgerId, entryId);
}
- return;
}
}