lhotari commented on code in PR #23352:
URL: https://github.com/apache/pulsar/pull/23352#discussion_r1792572331
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java:
##########
@@ -109,6 +116,11 @@ public void removeConsumer(Consumer consumer) {
}
}
}
+ ConsumerHashAssignmentsSnapshot assignmentsAfter =
internalGetConsumerHashAssignmentsSnapshot();
+ ImpactedConsumersResult impactedConsumers =
+
consumerHashAssignmentsSnapshot.resolveImpactedConsumers(assignmentsAfter);
Review Comment:
Here's a follow up to PIP-379 regarding the performance concerns of
snapshotting:
https://github.com/apache/pulsar/pull/23423
The snapshots are only needed for AUTO_SPLIT ordered mode. The changes in
the PR will make it so that all other use cases don't use snapshotting.
Any unnecessary work that can be avoided is a useful optimization, although
the performance of the current snapshotting isn't a concern based on the
microbenchmark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
