lhotari commented on code in PR #23222: URL: https://github.com/apache/pulsar/pull/23222#discussion_r1793496363
########## pip/pip-375.md: ########## @@ -0,0 +1,58 @@ +# PIP-375: Expose the Admin client configs: readTimeout, requestTimeout, connectionTimeout + +# Background knowledge + +- `pulsar-admin sinks create` will upload files to brokers, but if the file is large and the network is slow, it may cost a long time. +- The default value of `requestTimeout` of Admin API is `60s`, after the fix https://github.com/apache/pulsar/pull/23128, it was changed to `300s`. + +# Motivation + +We'd better to expose the following configs to users: + +```properties +# The value is the timeout to build a connection to the server. Value 0 represents infinity. Negative values are not allowed. +connectionTimeout + +# The value is the timeout to read a response. If the server doesn't respond within the defined timeframe, ProcessingException is thrown with TimeoutException as a cause. Review Comment: It's better to have clear descriptions for the settings. You could use GitHub Copilot to revisit the comment based on the feedback to assist in coming up with an improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
