codelipenghui commented on code in PR #23458:
URL: https://github.com/apache/pulsar/pull/23458#discussion_r1800437709
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1318,8 +1318,9 @@ public void deleteTopicAuthenticationWithRetry(String
topic, CompletableFuture<V
private CompletableFuture<Optional<Topic>> createNonPersistentTopic(String
topic) {
CompletableFuture<Optional<Topic>> topicFuture = new
CompletableFuture<>();
topicFuture.exceptionally(t -> {
+ // If the broker is not the owner of the topic, the client will
redirect to another broker.
+ // In this case, we should not record as a topic load failure.
pulsarStats.recordTopicLoadFailed();
- pulsar.getExecutor().execute(() -> topics.remove(topic,
topicFuture));
Review Comment:
Oh, it's not intentional. I will revert it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
