Re: [I] [Bug] Redelivering messages doesn't take dispatcherMaxReadSizeBytes into account in Shared and Key_Shared subscriptions [pulsar]

Wed, 23 Oct 2024 05:57:38 -0700 


ZhaoGuorui666 commented on issue #23505:
URL: https://github.com/apache/pulsar/issues/23505#issuecomment-2432068193

   Hi lhotari,
   
   I have been looking into this issue today and noticed that you have 
self-assigned it. I would like to discuss the following points with you:
   
   Where is the dispatcherMaxReadSizeBytes limit applied in the code?
   
   * Before inserting into the replay queue?
   
![image](https://github.com/user-attachments/assets/f905b510-40c7-4acc-9ee4-6f77596cf3a5)
   
   * Within the readMoreEntries() method? (However, I noticed that the 
calculateToRead() method already imposes a limit at the beginning)
   
![image](https://github.com/user-attachments/assets/a170da1f-57cf-4f3b-9eef-09ca81f45140)
   
   Looking forward to your PR and learning from your approach to resolving this 
issue.
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to