lhotari commented on code in PR #23502:
URL: https://github.com/apache/pulsar/pull/23502#discussion_r1813113844
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java:
##########
@@ -906,6 +906,49 @@ public void
testHasMessageAvailableAfterSeekTimestamp(boolean initializeLastMess
}
}
+ @Test(dataProvider = "initializeLastMessageIdInBroker")
+ public void
testHasMessageAvailableAfterSeekTimestampWithMessageIdInclusive(boolean
initializeLastMessageIdInBroker)
Review Comment:
I don't really understand the purpose of `initializeLastMessageIdInBroker`.
I tried looking at the existing tests that have it, but I don't see why it's
used. Could it be removed from this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
