summeriiii opened a new pull request, #23508: URL: https://github.com/apache/pulsar/pull/23508
Fixes https://github.com/apache/pulsar/issues/23498 ### Motivation The `Consumer#seek(long)` and `startMessageIdInclusive` have no relation. Whether startMessageIdInclusive is present or not, Consumer#seek(long) that seek by timestamp will contain the firstMessageId. In the code, we can see that the `Consumer#seek(long)` seekMessageId use the MessageId.earliest. ```java @Override public CompletableFuture<Void> seekAsync(long timestamp) { String seekBy = String.format("the timestamp %d", timestamp); long requestId = client.newRequestId(); return seekAsyncInternal(requestId, Commands.newSeek(consumerId, requestId, timestamp), MessageId.earliest, timestamp, seekBy); } ``` ### Modifications remove the `Consumer#seek(long)` in comment of `ReaderBuilder#startMessageIdInclusive` and `ConsumerBuilder#startMessageIdInclusive` ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [x] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
