liangyepianzhou commented on code in PR #23525:
URL: https://github.com/apache/pulsar/pull/23525#discussion_r1822179028


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationData.java:
##########
@@ -189,6 +189,8 @@ public class ProducerConfigurationData implements 
Serializable, Cloneable {
     )
     private CompressionType compressionType = CompressionType.NONE;
 
+    private int compressMinMsgBodySize = 4 * 1024; // 4kb

Review Comment:
   - It is default value for rocket mq.
   
https://github.com/apache/rocketmq/blob/dd62ed0f3b16919adec5d5eece21a1050dc9c5a0/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java#L117
   - And in my testing (against Pulsar Producer), when the message body is in 
the 3k-5k range, the CPU usage of compressing the same data starts to drop 
significantly and the compression rate increases significantly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to