nodece commented on PR #1301: URL: https://github.com/apache/pulsar-client-go/pull/1301#issuecomment-2446440729
This feature is good to me, I have some questions: 1. Why does the `AckIDList` not support ack the incomplete batch message, when the users use that, it is confusing. 2. Why not refactor the ` ackIDCommon(msgID MessageID, withResponse bool, txn Transaction)`, we can use `trackingMessageID` to track the batch message. Right now , the `ackIDCommon` and `AckIDList` have the duplication code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
