eolivelli commented on code in PR #23524:
URL: https://github.com/apache/pulsar/pull/23524#discussion_r1829076284
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/RangeEntryCacheImpl.java:
##########
@@ -362,6 +362,9 @@ private AsyncCallbacks.ReadEntriesCallback
handlePendingReadsLimits(ReadHandle l
}
long estimatedReadSize = (1 + lastEntry - firstEntry)
* (estimatedEntrySize + BOOKKEEPER_READ_OVERHEAD_PER_ENTRY);
+ if (estimatedReadSize > pendingReadsLimiter.getMaxReadsInFlightSize())
{
+ pendingReadsLimiter.setMaxReadsInFlightSize(estimatedReadSize);
Review Comment:
Here we are mutating the configuration of a shared object.
We could log an error but in the end the administrator has to change the
value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
