congbobo184 commented on PR #20032: URL: https://github.com/apache/pulsar/pull/20032#issuecomment-2459498198
> @congbobo184 To me it seems that the problem could be prevented by changing the this line > > https://github.com/apache/pulsar/blob/8eeb0e2e89f8938348d29044d9e1d843a6251067/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L898 > > > I'm assuming that instead of passing `CONSUMER_EPOCH.get(this)`, using `DEFAULT_CONSUMER_EPOCH` would solve the issue. It might also require changes so that DEFAULT_CONSUMER_EPOCH would always redeliver messages on the broker side. The client side seems to already always accept DEFAULT_CONSUMER_EPOCH. > Do you agree that this would solve the problem? DEFAULT_CONSUMER_EPOCH as seem as CONSUMER_EPOCH.get(this), we need to solves the reconnect and redeliver race condition, Using DEFAULT_CONSUMER_EPOCH seems to make the problem more complicated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
