lhotari commented on code in PR #973: URL: https://github.com/apache/pulsar-site/pull/973#discussion_r1832442986
########## docs/cookbooks-retention-expiry.md: ########## @@ -37,7 +37,7 @@ Pulsar's [admin interface](admin-api-overview.md) enables you to manage both ret By default, when a Pulsar message arrives at a broker, the message is stored until it has been acknowledged on all subscriptions, at which point it is marked for deletion. You can override this behavior and retain messages that have already been acknowledged on all subscriptions by setting a *retention policy* for all topics in a given namespace. Retention is based on both a *size limit* and a *time limit*. The diagram below illustrates the concept of message retention. - + Review Comment: I don't think that 3MB is much in repository size. How many files are there for the diagram files? Let's keep them in pulsar-site git repository, for example in `diagrams` sub directory. That would get ignored in the Docusaurus build so the website size wouldn't increase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
