onobc commented on code in PR #194:
URL:
https://github.com/apache/pulsar-client-reactive/pull/194#discussion_r1837451526
##########
buildSrc/src/main/groovy/pulsar-client-reactive.library-conventions.gradle:
##########
@@ -19,8 +19,7 @@
plugins {
id 'java-library'
- id 'maven-publish'
- id 'signing'
+ id 'pulsar-client-reactive.publish-conventions'
Review Comment:
> [!NOTE]
> I pulled the publishing piece out into its own plugin as the BOM uses
java-platform and the library modules use java-project and they do not play
well. Now each user of the publish conventions specifies the `from XYZ` part of
the `publications` block.
Messing w/ publishing things can be scary. To easy the fear, I did a
`./gradlew pTML` before and after this change and then did a folder compare and
made sure the poms and module files were identical before and after. Only the
local versions w/ the particular timestamp entry in the files were modified. I
am comfortable and confident that this change is not a risk in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
