nodece commented on code in PR #23590:
URL: https://github.com/apache/pulsar/pull/23590#discussion_r1837588398
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/EventLoopUtil.java:
##########
@@ -122,6 +122,16 @@ public static Class<? extends ServerSocketChannel>
getServerSocketChannelClass(E
}
}
+ public static Class<? extends SocketChannel>
getSocketChannelClass(EventLoopGroup eventLoopGroup) {
+ if (eventLoopGroup instanceof IOUringEventLoopGroup) {
+ return IOUringSocketChannel.class;
+ } else if (eventLoopGroup instanceof EpollEventLoopGroup) {
+ return EpollSocketChannel.class;
+ } else {
+ return NioSocketChannel.class;
+ }
+ }
+
Review Comment:
```suggestion
```
Duplication code, please see `getClientSocketChannelClass`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
