lhotari commented on code in PR #23620:
URL: https://github.com/apache/pulsar/pull/23620#discussion_r1851538700


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -3702,6 +3702,11 @@ public double 
getLoadBalancerBandwidthOutResourceWeight() {
             doc = "SSL Factory plugin configuration parameters used by 
internal client.")
     private String brokerClientSslFactoryPluginParams = "";
 
+    @FieldContext(category = CATEGORY_SERVER, dynamic = true,
+            doc = "Topic name contains cluster, not allow be created 
automatically."
+    )
+    private boolean enableCreateLegacyTopic = false;

Review Comment:
   The config name `enableCreateLegacyTopic` is not optimal. Since this is 
related to `allowAutoTopicCreation`, it's better to share that prefix, for 
example `allowAutoTopicCreationWithLegacyNamingScheme` would be a more accurate 
config name. It should also be specified in the documentation that this config 
is only used when `allowAutoTopicCreation=true`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to